Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winit version 0.29.4 #3239

Merged
merged 14 commits into from
Nov 24, 2023
Merged

Winit version 0.29.4 #3239

merged 14 commits into from
Nov 24, 2023

Conversation

kchibisov
Copy link
Member

No description provided.

Jasper-Bekkers and others added 14 commits November 24, 2023 13:14
Fix typo and other small grammar corrections.
We decided to add `rwh_06` to the `default` list of features in the
`ndk` to [nudge users to upgrade], but this forces `winit` to always
(transitively) include `raw-window-handle 0.6` even if the user has
set a different `rwh_xx` feature on the `winit` crate.  `winit` already
forwards the respective `rwh_xx` feaure to the `ndk` crate anyway, so
this default should just be turned off.

At the time of writing this is the only `default` feature of the `ndk`.

Links: rust-mobile/ndk#434 (comment)
In case the AboutToWait event sets the control flow to another value
it's not being used on this iteration.

Fixes rust-windowing#3215.
The surface was automatically dropped due to new RAII type in SCTK
when dropping the Window, which was not the case at some point with
SCTK.

Thus destroying objects associated with it where causing issues
with some window managers.

Links: neovide/neovide#2109
@kchibisov
Copy link
Member Author

That's the only patch I've excluded #3219 , since I'm not quite sure about it. cc @daxpedda

@daxpedda
Copy link
Member

That's the only patch I've excluded #3219 , since I'm not quite sure about it. cc @daxpedda

That can be skipped, it has no effect on functionality.

@kchibisov kchibisov merged commit 43f29f0 into rust-windowing:v0.29.x Nov 24, 2023
50 checks passed
@kchibisov kchibisov deleted the rel-0294 branch November 24, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.