Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add minor changes, some from nu_ansi_term #17

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

PThorpe92
Copy link
Member

This is I believe all we need to publish the first release, and migrate Eza over to this new maintained version. It has the syntax upgrades from the first commit, it includes the bright colors from #12, with BrightBlack and BrightWhite more appropriately named, and the Default ANSI color added.

@PThorpe92
Copy link
Member Author

PThorpe92 commented Sep 1, 2023

Never mind... Ok somehow adding the Option<Rc<str>> field, which I guess doesn't implement the copy trait.. Breaks Eza, so disregard this for now while I try to figure this out

Copy link
Member

@gierens gierens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PThorpe92 PThorpe92 merged commit 61a1faa into rustadopt:main Sep 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants