Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use configured crypto provider for the platform verifier #293

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

Gelbpunkt
Copy link
Contributor

@Gelbpunkt Gelbpunkt commented Dec 17, 2024

rustls-platform-verifier's Verifier needs to be told about the provider that is being used, otherwise it would error if no process-wide default had been installed. with_provider_and_platform_verifier does create the ClientConfig with the crypto provider and then calls with_platform_verifier, but the platform verifier was previously never made aware of the crypto provider.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, thanks for that! Silly mistake...

Can you add in a commit that bumps the version number?

Signed-off-by: Jens Reidel <[email protected]>
@Gelbpunkt
Copy link
Contributor Author

Can you add in a commit that bumps the version number?

Done :)

@djc djc added this pull request to the merge queue Dec 17, 2024
Merged via the queue into rustls:main with commit b82a869 Dec 17, 2024
11 checks passed
@Gelbpunkt Gelbpunkt deleted the fix-crypto-provider-platform-verifier branch December 17, 2024 20:10
@djc
Copy link
Member

djc commented Dec 18, 2024

  • Published hyper-rustls v0.27.4 at registry crates-io
  • [new tag] v/0.27.4 -> v/0.27.4
  • Release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants