Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: misc CI improvements. #145

Merged
merged 7 commits into from
Aug 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 51 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,37 @@
name: ci

on: [push, pull_request]
on:
push:
pull_request:
merge_group:
schedule:
- cron: '0 18 * * *'

env:
RUSTFLAGS: -D warnings
RUSTDOCFLAGS: -D warnings

jobs:
clippy:
name: Clippy
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v3
with:
persist-credentials: false
- name: Install rust toolchain
uses: dtolnay/rust-toolchain@stable
with:
components: clippy
- run: cargo clippy --all-features

build-windows:
runs-on: windows-latest
steps:
- uses: actions/checkout@master
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Install Rust
uses: dtolnay/rust-toolchain@master
with:
Expand All @@ -26,7 +48,6 @@ jobs:
- name: Run cargo doc
run: cargo doc --all --all-features


build:
strategy:
matrix:
Expand All @@ -39,11 +60,11 @@ jobs:
toolchain: nightly
- os: macOS-latest
toolchain: stable 7 months ago

runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@master
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Install Rust
uses: dtolnay/rust-toolchain@master
with:
Expand All @@ -57,3 +78,27 @@ jobs:
run: cargo test --verbose --features x509-parser
- name: Run cargo doc
run: cargo doc --all --all-features

coverage:
name: Measure coverage
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v3
with:
persist-credentials: false
- name: Install cargo-llvm-cov
uses: taiki-e/install-action@cargo-llvm-cov
- name: Install rust toolchain
uses: dtolnay/rust-toolchain@stable
with:
components: llvm-tools
- name: Measure coverage
cpu marked this conversation as resolved.
Show resolved Hide resolved
run: cargo llvm-cov --all-features --lcov --output-path ./lcov.info
- name: Report to codecov.io
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./lcov.info
fail_ci_if_error: false
verbose: true
2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ impl DnType {
pub enum DnValue {
/// A string of characters from the T.61 character set
TeletexString(Vec<u8>),
/// An ASCII string containing only A-Z, a-z, 0-9, '()+,-./:=? and <SPACE>
/// An ASCII string containing only A-Z, a-z, 0-9, '()+,-./:=? and `<SPACE>`
PrintableString(String),
/// A string encoded using UTF-32
UniversalString(Vec<u8>),
Expand Down
Loading