Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved how references test handles paths #4242

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

RunDevelopment
Copy link
Contributor

This is a PR for the improvements I made in #4216.

Changes:

  1. All paths are now relative to the repo root instead of cwd. This means that the test will work no matter the cwd. I did this to make debuggers work with references.rs without any config. Debuggers in VSCode can be configured to use a different cwd, but that would require creating a .vscode/launch.json. Now the default debugger just works.
  2. The compiler output is longer in /target but /target/tests/reference. The old target messed up incremental compilation for references.rs itself, which meant that running references.rs always meant compiler 50 or so deps before every run. On my old laptop, this means that running references.rs was 2 minutes of compiling and 30 sec of running tests, every time.

Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@daxpedda daxpedda merged commit 61e50b6 into rustwasm:main Nov 7, 2024
41 checks passed
@RunDevelopment RunDevelopment deleted the reference-paths branch November 7, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants