Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved CMAKE_CXX_STANDARD from 14 to 17 #396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ipcamit
Copy link

@ipcamit ipcamit commented Mar 18, 2025

This moves the CMAKE_CXX_STANDARD from 14 to 17. Without is the libtorchsparse is triggering libtorch CXX 17 required error.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.09%. Comparing base (2d55981) to head (517a310).
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #396   +/-   ##
=======================================
  Coverage   73.09%   73.09%           
=======================================
  Files          29       29           
  Lines        1171     1171           
=======================================
  Hits          856      856           
  Misses        315      315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants