3x speedup of the distance transform. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By avoiding checked adds and instead manually iterating over the correct windows of `RoomXY`s, we obtain a 3x speedup over the naive `filter_map`-based implementation.
khoover
commented
Sep 9, 2024
Comment on lines
-35
to
-36
| // Copy the initial cost matrix into the output cost matrix | ||
| let mut cm = initial_cm.clone(); |
There was a problem hiding this comment.
We actually never needed this clone, since we get the cost-matrix by value; the old owner can't do anything with it.
Get rid of the windowing vector, map to the array of surrounding y- coordinates.
shanemadden
approved these changes
Sep 10, 2024
shanemadden
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By avoiding checked adds and instead manually iterating over the correct windows of
RoomXYs, we obtain a 3x speedup over the naivefilter_map-based implementation.