Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright test changes #29

Merged
merged 12 commits into from
May 16, 2024
Merged

Playwright test changes #29

merged 12 commits into from
May 16, 2024

Conversation

aashwin-rvvup
Copy link
Contributor

  • Works with our existing test store and the test data setup on these stores (in the future we will be able to spin up test stacks with the data on demand)
  • Update config to be a bit more reliable (remove parallelisation as it affects current test store rate limiting), update base url to be passed in as an env variable.

Copy link
Contributor

@valentin-rvvup valentin-rvvup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy with the changes. Great job 👏
Few suggestions for the docs.

  1. Update the README.md to match the magento-plugin one
npm i
npx playwright install
...
  1. In README.md, specify (1) the need to end domain on a trailing slash / and (2) to specify subdomain
# Point to your base url, including subdomain (www) and trailing slash (path/)
ENV TEST_BASE_URL=https://www.domain.com/path/ npx playwright test --ui

Copy link
Contributor

@valentin-rvvup valentin-rvvup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Works like a charm.

I would suggest updating the .env.sample to clarify how to obtain + set the Hyva SSH private key. Something like

# Use the private key matching one of the public keys on gitlab.hyva.io
HYVA_SSH_PRIVATE_KEY="Private key goes here"

@aashwin-rvvup aashwin-rvvup merged commit 5b8384f into main May 16, 2024
@aashwin-rvvup aashwin-rvvup deleted the playwright-tests branch May 16, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants