Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix feature extraction #32

Merged
merged 4 commits into from
Aug 30, 2023
Merged

fix feature extraction #32

merged 4 commits into from
Aug 30, 2023

Conversation

michelwi
Copy link
Contributor

When using the LogMelFeatureExtractionV1 I encountered the following problems:

  • f_min==0 was disallowed. It is allowed for filters.mel.
  • if no win_length is given, then it is treated as n_fft, which is not always correct
  • n_fft of the config was not set correctly

@albertz
Copy link
Member

albertz commented Aug 24, 2023

I think using torch.clamp instead of torch.max allows you to use a float directly.

@michelwi michelwi force-pushed the willi-fix-feature-extraction branch from bd24862 to 97f0440 Compare August 24, 2023 17:02
Copy link
Contributor

@JackTemaki JackTemaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buffer change will break some of my setups, but that is okay, I will change them accordingly later on.

@michelwi michelwi merged commit 95f5521 into main Aug 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants