-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix feature extraction #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelwi
requested review from
albertz,
christophmluscher,
JackTemaki and
Atticus1806
August 24, 2023 13:31
albertz
reviewed
Aug 24, 2023
albertz
approved these changes
Aug 24, 2023
I think using |
albertz
reviewed
Aug 24, 2023
Co-authored-by: Albert Zeyer <[email protected]>
michelwi
force-pushed
the
willi-fix-feature-extraction
branch
from
August 24, 2023 17:02
bd24862
to
97f0440
Compare
Atticus1806
approved these changes
Aug 28, 2023
SimBe195
approved these changes
Aug 28, 2023
JackTemaki
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The buffer change will break some of my setups, but that is okay, I will change them accordingly later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
LogMelFeatureExtractionV1
I encountered the following problems:win_length
is given, then it is treated asn_fft
, which is not always correctn_fft
of the config was not set correctly