-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add setup_job_directory shortcut #98
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a job isn't inside the graph this will probably crash since tk.sis_graph.find("%s")
returns an empty array. Given that you check each config file individually it will not work if the first config file doesn't contain the job.
Either pass all config files at once or allow only one config file as input.
@@ -179,6 +188,12 @@ def remove_job_and_descendants(args): | |||
call_sis(call) | |||
|
|||
|
|||
def setup_job_directory(args): | |||
for conf_file in args.argv: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does passing all config files at once cause problems?
I don't mind having this shortcut. @JackTemaki is this still relevant for you? |
Well, this is just a small convenience increase that you do not have to open the console for that, I would not call it relevant. |
some similar functionality is available now via #239, should we close this? |
No description provided.