name and kind filters are not case-sensitive (#2)

ryane · Jul 4, 2019 · 3d2093f · 3d2093f
1 parent 109c8bb
commit 3d2093f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/pkg/filter/kind_filter.go b/pkg/filter/kind_filter.go
@@ -21,7 +21,7 @@ func (f *kindMatcher) Match(u unstructured.Unstructured) bool {
 	}
 
 	for _, kind := range f.kinds {
-		if kind == u.GetKind() {
+		if strings.EqualFold(kind, u.GetKind()) {
 			return true
 		}
 	}

diff --git a/pkg/filter/kind_filter_test.go b/pkg/filter/kind_filter_test.go
@@ -35,6 +35,7 @@ func TestKindFilter(t *testing.T) {
 	}{
 		{[]string{"ServiceAccount"}, []string{"test-sa", "test-sa-2"}},
 		{[]string{"Deployment"}, []string{"test-deployment"}},
+		{[]string{"deployment"}, []string{"test-deployment"}},
 		{[]string{"Pod"}, []string{"test-pod"}},
 		{[]string{"ServiceAccount", "Deployment"}, []string{"test-sa", "test-sa-2", "test-deployment"}},
 	}

diff --git a/pkg/filter/name_filter.go b/pkg/filter/name_filter.go
@@ -21,7 +21,7 @@ func (f *nameMatcher) Match(u unstructured.Unstructured) bool {
 	}
 
 	for _, name := range f.names {
-		if name == u.GetName() {
+		if strings.EqualFold(name, u.GetName()) {
 			return true
 		}
 	}

diff --git a/pkg/filter/name_filter_test.go b/pkg/filter/name_filter_test.go
@@ -36,6 +36,7 @@ func TestNameFilter(t *testing.T) {
 		{[]string{"test-sa"}, []string{"test-sa"}},
 		{[]string{"test-sa", "test-sa-2"}, []string{"test-sa", "test-sa-2"}},
 		{[]string{"test-deployment"}, []string{"test-deployment"}},
+		{[]string{"TEST-DEPLOYMENT"}, []string{"test-deployment"}},
 		{[]string{"test-deployment", "test-pod"}, []string{"test-pod", "test-deployment"}},
 	}