Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the stream not closing on error and closing before the file write operation #9

Merged
merged 2 commits into from
May 16, 2023
Merged

Fix the stream not closing on error and closing before the file write operation #9

merged 2 commits into from
May 16, 2023

Conversation

volskaya
Copy link
Contributor

No description provided.

@ryanheise
Copy link
Owner

Thanks, @volskaya . Can you link this to a bug report so that it can be tested?

@ryanheise ryanheise merged commit 04e7e7f into ryanheise:master May 16, 2023
@ryanheise
Copy link
Owner

I have now merged this into master. It seems some of these changes were also incorporated into #12 but after merging #9 I believe I've sorted out the overlap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volskaya @ryanheise