Merge pull request #107 from ryanluker/131-cleanup

Cleanup bugs from 1.3.0 release
ryanluker · Jan 29, 2018 · 3e2062a · 3e2062a
2 parents cbad7d1 + aa09de2
commit 3e2062a
Show file tree

Hide file tree

Showing 11 changed files with 1,529 additions and 587 deletions.
diff --git a/README.md b/README.md
@@ -27,7 +27,7 @@
 - colour compatibility with light and dark themes
 
 ## Requirements
-- vscode 1.17.0 and up
+- vscode 1.19.0 and up
 - macos, linux or windows
 
 ## Extension Settings

diff --git a/example/node/test-coverage.js b/example/node/test-coverage.js
@@ -9,14 +9,19 @@ module.exports.test = function test(testNumber) {
     if(testNumber === 3) return "notNull";
     if(testNumber === 4) return "reallyNull";
 
-    testNumber = testNumber === 5 ? "woop":"wap";
-
-    const testComplexReturn = callbackBased(111, subTest);
-
-    if(testNumber === 6) {
+    testObj = {
+        attr1: true,
+        attr2: true,
+        attr3: true
+    };
+    if(testObj.attr1 && testObj.attr2 && callbackBased(testNumber, subTest)) {
         testNumber = testNumber ? subTest(testNumber) : "neverhappen";
     }
 
+    testNumber = testNumber === 5 ? "woop":"wap";
+
+    const testComplexReturn = callbackBased(111, subTest);
+
     return testNumber;
 }
 

diff --git a/example/node/test.js b/example/node/test.js
@@ -14,13 +14,23 @@ describe('test func', function() {
         assert(num==="reallyNull");
     });
 
+    it('should show coverage', function() {
+        var num = testFunc(3);
+        assert(num==="notNull");
+    });
+
+    it('should show coverage', function() {
+        var num = testFunc(9);
+        assert(true);
+    });
+
     it('should show coverage on line 9', function() {
         var num = testFunc(7);
         assert(num==="wap");
     });
 
     it('should show coverage on line 9 x2', function() {
         var num = testFunc(5);
-        assert(num==="woop");
+        assert(num==="wap");
     });
 });