[#134] Fix tests and adjust send event

ryanluker · Jul 1, 2018 · 7fbcea9 · 7fbcea9
1 parent fc62dad
commit 7fbcea9
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 30 deletions.
diff --git a/src/extension.ts b/src/extension.ts
@@ -7,14 +7,10 @@ import {Reporter} from "./reporter";
 import {StatusBarToggler} from "./statusbartoggler";
 import {Fs} from "./wrappers/fs";
 import {Glob} from "./wrappers/glob";
-import {LcovParse} from "./wrappers/lcov-parse";
 import {Request} from "./wrappers/request";
 import {Vscode} from "./wrappers/vscode";
-import {XmlParse} from "./wrappers/xml-parse";
 
 const fsImpl = new Fs();
-const xmlParseImpl = new XmlParse();
-const lcovParseImpl = new LcovParse();
 const vscodeImpl = new Vscode();
 const globImpl = new Glob();
 

diff --git a/src/renderer.ts b/src/renderer.ts
@@ -124,8 +124,8 @@ export class Renderer {
             const message = template + `${filePath} [exactness score]: ${topSection.score}`;
             this.outputChannel.appendLine(message);
             // log event and file type
-            this.eventReporter.sendEvent("system", "renderer", "correctness", topSection.score);
-            this.eventReporter.sendEvent("system", "renderer", "fileType", extname(filePath));
+            this.eventReporter.sendEvent("system", "renderer-correctness", topSection.score.toString());
+            this.eventReporter.sendEvent("system", "renderer-fileType", extname(filePath));
         }
 
         return topSection.section;

diff --git a/src/reporter.ts b/src/reporter.ts
@@ -20,7 +20,7 @@ export class Reporter {
         category: string,
         action: string,
         label?: string,
-        value?: number | string,
+        value?: number,
     ) {
         if (!this.enableMetrics) { return; }
         const data = {

diff --git a/src/wrappers/lcov-parse.ts b/src/wrappers/lcov-parse.ts
diff --git a/src/wrappers/xml-parse.ts b/src/wrappers/xml-parse.ts
diff --git a/test/renderer.test.ts b/test/renderer.test.ts
@@ -31,8 +31,12 @@ suite("Renderer Tests", function() {
         show: () => {},
     };
 
+    const fakeReporter = {
+        sendEvent: () => {},
+    }
+
     test("Constructor should setup properly @unit", function(done) {
-        assert.doesNotThrow(() => new Renderer(fakeConfig, fakeOutput));
+        assert.doesNotThrow(() => new Renderer(fakeConfig, fakeOutput, fakeReporter as any));
         return done();
     });
 });