Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up 03-extension-types #121

Merged
merged 4 commits into from
Oct 22, 2023
Merged

Conversation

TashiWalde
Copy link
Collaborator

@TashiWalde TashiWalde commented Oct 14, 2023

This is mostly a housekeeping PR cleaning up 03-extension-types.

  • Formatting improvements
  • Restructured the section about homotopy extension property a bit and added subheaders.
  • The proof of RS-4.11 is now in its own subsection. We might consider removing this subsection, since it is kinda redundant given the direct implication weakextext-naiveextext. Maybe @emilyriehl wants to weigh in on this?
  • Removed the redundant term eq-ext-htpy, which is the same as naiveextext-extext.
  • Removed one copy of Prop 4.10. For some reason this formalization was duplicated.

In terms of new formalizations:

  • Added functorial instances of curry-uncurry, uncurry-opcurry, fubini.
  • Added a very short direct proof htpy-ext-prop-extext that extension extensionality implies the homotopy extension property.

Copy link
Collaborator

@emilyriehl emilyriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TashiWalde this looks great.

I guess for completeness sake, let's leave the redundant 4.11 there for now. I like the compromise of putting it in its own section towards the end.

Maybe in the future we move some of the redundant formalizations elsewhere (eg to the Yoneda repository?) and work on improving the efficiency of the sHoTT repository overall. But this is clearly a broader discussion we all should weigh in on.

@emilyriehl emilyriehl merged commit 8d5b0be into rzk-lang:main Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants