-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependent Composition #144
Conversation
…s, does one of them produce composition over a Segal type?
Why does this PR have such an exciting history (closed, reopened, marked draft, ... ) |
The code looks great. I've suggested a few renamings (feel free to push back @thchatzidiamantis). Let's also have someone else figure out what happened with the agda thing in the settings file. |
Great work @thchatzidiamantis and @nimarasekh! I also have a version for a more general setting over in the yoneda repo, not yet integrated into sHoTT: https://github.com/emilyriehl/yoneda/blob/master/src/simplicial-hott/12-cocartesian.rzk.md |
Did you commit these changes you are suggesting or is something wrong on my side? Cause I can't see them. |
I think all the work here is @thchatzidiamantis with tremendous help by @emilyriehl and nothing by me. Also yeah you should add your result to the library, why not? |
Updated the names as suggested by @emilyriehl. |
I'm happy with everything in the covariant file. @fizruk should the change to settings.json be kept or reversed? I also possibly introduced a formatting error that I don't understand. |
Fixed formatting, removed agda thing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge.
No description provided.