Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependent Composition #144

Merged
merged 43 commits into from
Jul 16, 2024
Merged

Dependent Composition #144

merged 43 commits into from
Jul 16, 2024

Conversation

thchatzidiamantis
Copy link
Contributor

No description provided.

@thchatzidiamantis thchatzidiamantis marked this pull request as draft June 21, 2024 16:43
@thchatzidiamantis thchatzidiamantis marked this pull request as ready for review June 21, 2024 20:00
.vscode/settings.json Outdated Show resolved Hide resolved
@nimarasekh
Copy link
Collaborator

Why does this PR have such an exciting history (closed, reopened, marked draft, ... )

@emilyriehl
Copy link
Collaborator

The code looks great. I've suggested a few renamings (feel free to push back @thchatzidiamantis). Let's also have someone else figure out what happened with the agda thing in the settings file.

@jonweinb
Copy link
Collaborator

jonweinb commented Jul 9, 2024

Great work @thchatzidiamantis and @nimarasekh!

I also have a version for a more general setting over in the yoneda repo, not yet integrated into sHoTT: https://github.com/emilyriehl/yoneda/blob/master/src/simplicial-hott/12-cocartesian.rzk.md
Happy to do that soon, and coordinate as appropriate.

@nimarasekh
Copy link
Collaborator

The code looks great. I've suggested a few renamings (feel free to push back @thchatzidiamantis). Let's also have someone else figure out what happened with the agda thing in the settings file.

Did you commit these changes you are suggesting or is something wrong on my side? Cause I can't see them.

@nimarasekh
Copy link
Collaborator

Great work @thchatzidiamantis and @nimarasekh!

I also have a version for a more general setting over in the yoneda repo, not yet integrated into sHoTT: https://github.com/emilyriehl/yoneda/blob/master/src/simplicial-hott/12-cocartesian.rzk.md Happy to do that soon, and coordinate as appropriate.

I think all the work here is @thchatzidiamantis with tremendous help by @emilyriehl and nothing by me. Also yeah you should add your result to the library, why not?

.vscode/settings.json Outdated Show resolved Hide resolved
src/simplicial-hott/08-covariant.rzk.md Outdated Show resolved Hide resolved
src/simplicial-hott/08-covariant.rzk.md Show resolved Hide resolved
src/simplicial-hott/08-covariant.rzk.md Outdated Show resolved Hide resolved
src/simplicial-hott/08-covariant.rzk.md Outdated Show resolved Hide resolved
src/simplicial-hott/08-covariant.rzk.md Outdated Show resolved Hide resolved
src/simplicial-hott/08-covariant.rzk.md Outdated Show resolved Hide resolved
src/simplicial-hott/08-covariant.rzk.md Show resolved Hide resolved
@thchatzidiamantis
Copy link
Contributor Author

Updated the names as suggested by @emilyriehl.

@emilyriehl
Copy link
Collaborator

emilyriehl commented Jul 14, 2024

I'm happy with everything in the covariant file. @fizruk should the change to settings.json be kept or reversed?

I also possibly introduced a formatting error that I don't understand.

@thchatzidiamantis
Copy link
Contributor Author

Fixed formatting, removed agda thing

Copy link
Collaborator

@emilyriehl emilyriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@emilyriehl emilyriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge.

@emilyriehl emilyriehl merged commit 352c301 into rzk-lang:main Jul 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants