Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak FunExt implies FunExt #145

Merged
merged 8 commits into from
Jul 30, 2024
Merged

Conversation

thchatzidiamantis
Copy link
Contributor

Converse direction for #73. Also added a naive-funext axiom.

@emilyriehl
Copy link
Collaborator

The code looks good but the exposition could be improved. Start the new section with some text that explains what you are planning to do and how the proof will go. The citation to Rijke doesn't appear to be in the right place. If you are formalizing a specific result in that book, then you can use the title="blah" tag immediately before the definition that corresponds to that result. Here it appears you are citing an entire section, so I would do this in the body of the comment and not with a title.

Can we come up with a better name for "WeirdFunExt". Similarly how should I interpret the name of the first term you define? Feel free to ask questions about this on the zulip.

@thchatzidiamantis
Copy link
Contributor Author

Changes to the exposition. I did not make any name changes on my own, I would be happy to discuss and rename as appropriate.

Copy link
Collaborator

@emilyriehl emilyriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a better name for WeirdFunExt, but let's fix this later.

@emilyriehl emilyriehl merged commit 436ceb5 into rzk-lang:main Jul 30, 2024
2 checks passed
@thchatzidiamantis thchatzidiamantis deleted the Contractible branch July 30, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants