Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak ext ext #70

Merged
merged 13 commits into from
Oct 1, 2023
Merged

Weak ext ext #70

merged 13 commits into from
Oct 1, 2023

Conversation

jonalfcam
Copy link
Collaborator

Progress towards RS Prop 4.11. A helper function that defines $c(t) = refl$ from the proposition.

@jonalfcam
Copy link
Collaborator Author

More progress towards the end of section 4. This will require a refactor to get the logic of the section correct, but all of the necessary functions are now there.

@emilyriehl
Copy link
Collaborator

@jonalfcam it sounds like you're still working on this and don't want us to review yet?

@emilyriehl
Copy link
Collaborator

While I'm here a request: since function extensionality is called funext let's use weakextext and weakfunext (no hyphens).

@jonalfcam
Copy link
Collaborator Author

Great! I'll fix those. Yes, this is a draft for the moment. Everything is correcet and typechecks, but in order to finish off the proof of Prop 4.11 I need to refactor so that the homotopy extension property is its own property and doesn't depend on weakextext. Once that is done (and I've appropriately renamed helper lemmas), that should finish off section 4 (modulo 4.12, which I might wait until the natural numbers are available to do).

@jonalfcam jonalfcam marked this pull request as ready for review September 29, 2023 18:36
@jonalfcam
Copy link
Collaborator Author

I have finished the proof of Prop. 4.11. There is a robust debate to be had about my naming conventions.

@jonalfcam
Copy link
Collaborator Author

It would appear that someone defined NaiveExtExt which I also defined a version of. I'm happy to change things over to that terminology to fix that particular conflict. Otherwise, I'm not sure how to resolve these.

@emilyriehl
Copy link
Collaborator

Hi @jonalfcam and @TashiWalde. I attempted to fix the merge conflicts, but now my flight boarding so I have to go.

In the current draft there are two versions of 4.10. I wasn't sure which came later and which is preserved. Could you two resolve this?

Elsewhere we use concatenation extext and funext so I think we should use weakextext and naiveextext. I wasn't sure what to call the homotopy extension property though.

@emilyriehl
Copy link
Collaborator

It's quite possible I made a mistake in resolving the conflicts so please look at this closely. Also I didn't check the markdown sections carefully. We typically use #!rzk a instead of $a$ but I understand why @jonalfcam wanted to use LaTeX for the extension types.

@jonalfcam
Copy link
Collaborator Author

jonalfcam commented Sep 30, 2023

It looks like this merge failed, but I see why. Unfortunately I am also boarding a plane. I can take care of it tomorrow.

@jonalfcam
Copy link
Collaborator Author

It’s the changes on line 697 in 04 that are the culprit. It looks like they were resolved to an old version.

@jonalfcam
Copy link
Collaborator Author

This now passes checks.

@emilyriehl emilyriehl merged commit 9ec8630 into main Oct 1, 2023
@emilyriehl emilyriehl deleted the weak-ext-ext branch October 1, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants