fix: Correct types for customInput property #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-yadav
reviewed
Feb 25, 2024
src/types.ts
Outdated
| @@ -52,7 +52,7 @@ export type InputAttributes = Omit< | |||
| type NumberFormatProps<Props, BaseType = InputAttributes> = Props & | |||
| Omit<InputAttributes, keyof BaseType> & | |||
| Omit<BaseType, keyof Props | 'ref'> & { | |||
| customInput?: React.ComponentType<BaseType>; | |||
| customInput?: React.ComponentType<React.InputHTMLAttributes<HTMLInputElement> & React.RefAttributes<HTMLInputElement>>; | |||
There was a problem hiding this comment.
This will force the customInput to be type of Input element. While custom Input can be any component, and the NumberFormatProps inherits from there.
Please check on number_format.spec.tsx, it must be failing.
There was a problem hiding this comment.
let me try to fix it, may be I need to rewrite a couple of types
splatonov92
commented
Aug 18, 2024
| @@ -46,7 +46,7 @@ export type ChangeMeta = { | |||
|
|
|||
| export type InputAttributes = Omit< | |||
| React.InputHTMLAttributes<HTMLInputElement>, | |||
| 'defaultValue' | 'value' | 'children' | |||
There was a problem hiding this comment.
FMI: why do you need to omit 'defaultValue' | 'value' from InputAttributes?
splatonov92
force-pushed
the
fix-customInput-type
branch
from
99d26af
to
634c28c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue/change
Any component containing
valueprops can not be passed ascustomInputproperty. Despite the fact that typing prohibits passing thecustomInputwithvalue,number_format_basepasses all props includingvaluetocustomInput.Add CodeSandbox link to illustrate the issue (If applicable)
Describe specs for failing cases if this is an issue (If applicable)
Describe the changes proposed/implemented in this PR
@ts-ignoredirectiveLink Github issue if this PR solved an existing issue
Example usage (If applicable)
Screenshot (If applicable)
Please check which browsers were used for testing