Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr #57, #89

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Pr #57, #89

wants to merge 4 commits into from

Conversation

RasenGUY
Copy link

pr for issue #57

what i have done

  • hosted a cors-anywhere proxy, used that link for github Oauth this way login in works
  • created an input component with submit button to for creating and submitting components
    • submit buttons becomes active once input text-area becomes dirty
    • editor can detect markdown (still a bit buggy, markdown strings aren't properly formatted if the comment in markdown syntax is to big)
  • create a gql query for querying the most recent comment
    • for updating the comments once the new comment is mutated with githubgql on issue
  • create a mutation (update) query for adding a comment to an issue

notes and considerations

  • would it be an idea to host the website somewhere like vercel, this way the sensitive information regarding oauth can be injected through an .env file (atm sensitive information is layed bare)
  • I think we need to add in the documentation a few lines on how to host your own cors-anywhere proxy and update the authenticate function in GithubCallBack.js to reflect this change.
  • the github app should also be granted permissions to read metadata (I had to include this is order for issues on my repositories to show on the website)

@vercel
Copy link

vercel bot commented Dec 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/saadpasta/react-blog-github/7AhkMj6vgApYJfn5dTa55KjtR6gf
✅ Preview: Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant