New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug fix] include shareMedium in analytics load event if available #62

Open

00salmon wants to merge 1 commit into master from analytics-fix

+9 −2

Contributor

00salmon commented Jul 12, 2024

Description of the change

shareMedium was not being included in analytics load event, this adds it to the query if available as a queryParam

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation or Development tools (readme, specs, tests, code formatting)

Links

Jira issue number: (PUT IT HERE)
Process.st launch checklist: (PUT IT HERE)

Checklists

Development

Prettier was run (if applicable)
The behaviour changes in the pull request are covered by specs
All tests related to the changed code pass in development

Paperwork

This pull request has a descriptive title and information useful to a reviewer
This pull request has a Jira number
This pull request has a Process.st launch checklist

Code review

Changes have been reviewed by at least one other engineer
Security impacts of this change have been considered


          include shareMedium in analytics load event if available

44fc51c

github-actions bot commented Jul 12, 2024 •

edited

Loading

A preview of is uploaded and can be seen here:

✨ https://saasquatch.github.io/squatch-js/pull/62 ✨

github-actions bot commented Jul 12, 2024

size-limit report 📦

Path	Size
dist/squatch.js	12.2 KB (+0.54% 🔺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet