Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/rename functions #123

Merged
merged 2 commits into from
May 25, 2024
Merged

Refactor/rename functions #123

merged 2 commits into from
May 25, 2024

Conversation

andreivladbrg
Copy link
Member

@andreivladbrg andreivladbrg commented May 25, 2024 •
edited by smol-ninja
Loading

Linked issues

PR dependencies

Changelog

  • Remove redundant "Stream" word from function names

@andreivladbrg andreivladbrg requested a review from smol-ninja May 25, 2024 14:02
@andreivladbrg andreivladbrg mentioned this pull request May 25, 2024
Merged
smol-ninja
smol-ninja approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There were a few more places which I have covered in 7e4b345.

@andreivladbrg andreivladbrg force-pushed the refactor/rename-functions branch from 7e4b345 to ee9fcb4 Compare May 25, 2024 16:44
@andreivladbrg
Copy link
Member Author

There were a few more places which I have covered in 7e4b345.

thank you

@andreivladbrg
Copy link
Member Author

hmm, the coverage has decreased, not sure why

@smol-ninja
Copy link
Member

I think we can ignore coverage for this PR and the next PR. That is probably because codecov wasn't aware about the repo name change. An hour ago, I discovered in the CI logs that it failed to upload the coverage report, so I went to codecov to sync flow repo. And when I did that, it probably did not copy codecov data from open-ended to flow project and thus lost track of head coverage.

Ref: https://codecov.freshdesk.com/support/solutions/articles/43000629044-repo-not-updating-after-transfer-rename

@andreivladbrg andreivladbrg merged commit 6bb0bb9 into main May 25, 2024
5 of 6 checks passed
@andreivladbrg andreivladbrg deleted the refactor/rename-functions branch May 27, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smol-ninja smol-ninja smol-ninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename restartStreamAndDeposit to restartAndDeposit Rename restartStream to restart
2 participants
@andreivladbrg @smol-ninja