-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC721 support #82
Conversation
test: remove ERC20 events test: add ERC721 transfer event test: remove unneded delegatecall tests test: update create tests
test: update tests accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since its a huge PR and there are so many ongoing changes for other open issues, should we merge it after the following review and start working on top of it? We can create more smaller issues if we find problem with it later. cc @andreivladbrg wdyt?
PS: I have't reviewed the tests yet.
While reviewing this PR, I have realized that it would have been easier to review it if it had been split into multiple PRs.
What do you think @PaulRBerg @andreivladbrg? imo we should avoid large PRs until its absolutely necessary. |
agree, let's split in multiple PRs |
feat: inherit IERC721Metadata in ISablierV2OpenEndedState refactor: add constructor in SablierV2OpenEnded
@smol-ninja I've pushed a new commit addressing some of your feedback And, as we discussed privately, we will merge this PR as is (to make things moving faster), and we will create future issues in case of problem |
yeah sounds good. |
Closes #47 #73 #66 #63
Changes
ERC721
inSablierV2OpenEndedState
_update
hook_isCallerStreamRecipientOrApproved
helper functionIERC4906
and addupdateMetadata
modifierStream
struct_extractFromStream
functionisTransferable
bool_create
functionERC20
transfers fromcancel
andadjustRatePerSecond
functionwithdrawableAmountOf
function to includeremainingAmount
README
README
src
Also, I've created some useful diagrams, but they will be correct once we make the
cancel
-->pause
change:Diagrams
State diagram
Calculation diagrams