Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: lower optimizer runs #1117

Merged
merged 2 commits into from
Dec 12, 2024
Merged

build: lower optimizer runs #1117

merged 2 commits into from
Dec 12, 2024

Conversation

andreivladbrg
Copy link
Member

@andreivladbrg andreivladbrg commented Dec 12, 2024 •
edited
Loading

The size of the SablierLockup contract passes the limit:

| SablierLockup                 |           25,069 |            26,085 |               -493 |              23,067 |

So we need to lower the optimizer runs to 800.
Also, update the package json version to 2.0.0

@andreivladbrg
build: decrease the optimizer runs
9ba2ade 
chore: use 2.0.0 version in package json
@andreivladbrg andreivladbrg changed the base branch from main to staging December 12, 2024 15:56
@andreivladbrg andreivladbrg requested review from PaulRBerg and smol-ninja and removed request for PaulRBerg December 12, 2024 15:56
smol-ninja
smol-ninja requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version change in test_ConstructCreate2Salt as well. Not sure why the PR did not trigger the CI

@andreivladbrg andreivladbrg merged commit b5e32cb into staging Dec 12, 2024
9 checks passed
@andreivladbrg andreivladbrg deleted the build/optimizer-runs branch December 12, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smol-ninja smol-ninja smol-ninja requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreivladbrg @smol-ninja