-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish deploy-multi-chain script #744
Polish deploy-multi-chain script #744
Conversation
@andreivladbrg let me know if looks good. I had to change |
a0b9658
to
f512de7
Compare
f512de7
to
7706379
Compare
github secrets can be updated as well, my intention is to switch from RPC_URL_{CHAIN_NAME} to {CHAIN_NAME}_RPC_URL because it is easier to group them and to alphabetically order in |
Agree. I've changed it back 083d6d7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the comptrollers here with the intention of adding a deploy core 3 script that does not deploy the comptroller. Can you also verify if there have been any changes between release
and staging
in src/SablierV2Comptroller
or src/interfaces/ISablierV2Comptroller
?
build: use deploy core 3 scripts
pushed two commits, lmk if it looks good now |
LGTM! |
9991191
into
build/multi-chain-script
Closes #743