test: remove unnecessary unchecked blocks

test: undo changes in Murky.sol
sablier-labs · Jan 6, 2024 · f05633f · f05633f
1 parent 726223c
commit f05633f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 17 deletions.
diff --git a/test/utils/ArrayBuilder.sol b/test/utils/ArrayBuilder.sol
@@ -14,9 +14,7 @@ library ArrayBuilder {
     {
         streamIds = new uint256[](batchSize);
         for (uint256 i = 0; i < batchSize; ++i) {
-            unchecked {
-                streamIds[i] = firstStreamId + i;
-            }
+            streamIds[i] = firstStreamId + i;
         }
     }
 }
diff --git a/test/utils/BatchBuilder.sol b/test/utils/BatchBuilder.sol
@@ -17,9 +17,7 @@ library BatchBuilder {
     {
         batch = new Batch.CreateWithDeltas[](batchSize);
         for (uint256 i = 0; i < batchSize; ++i) {
-            unchecked {
-                batch[i] = batchSingle;
-            }
+            batch[i] = batchSingle;
         }
     }
 
@@ -56,9 +54,7 @@ library BatchBuilder {
     {
         batch = new Batch.CreateWithDurations[](batchSize);
         for (uint256 i = 0; i < batchSize; ++i) {
-            unchecked {
-                batch[i] = batchSingle;
-            }
+            batch[i] = batchSingle;
         }
     }
 
@@ -95,9 +91,7 @@ library BatchBuilder {
     {
         batch = new Batch.CreateWithMilestones[](batchSize);
         for (uint256 i = 0; i < batchSize; ++i) {
-            unchecked {
-                batch[i] = batchSingle;
-            }
+            batch[i] = batchSingle;
         }
     }
 
@@ -135,9 +129,7 @@ library BatchBuilder {
     {
         batch = new Batch.CreateWithRange[](batchSize);
         for (uint256 i = 0; i < batchSize; ++i) {
-            unchecked {
-                batch[i] = batchSingle;
-            }
+            batch[i] = batchSingle;
         }
     }
 

diff --git a/test/utils/Murky.sol b/test/utils/Murky.sol
@@ -27,8 +27,8 @@ abstract contract MurkyBase {
         // proof length must be less than max array size
         bytes32 rollingHash = valueToProve;
         uint256 length = proof.length;
-        for (uint256 i = 0; i < length; ++i) {
-            unchecked {
+        unchecked {
+            for (uint256 i = 0; i < length; ++i) {
                 rollingHash = hashLeafPairs(rollingHash, proof[i]);
             }
         }