Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "ProxyPlugin" and "Archive" #213

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

andreivladbrg
Copy link
Member

Closes #212

For historical reasons, I have pushed a branch to keep the contracts, in case we need them at some point in the future.

@PaulRBerg
Copy link
Member

For historical reasons, I have pushed a branch to keep the contracts

You can remove it. Git itself is a history tracker, and we also have version tags, which we can easily checkout if the need arises for looking up these contracts in the future.

PaulRBerg
PaulRBerg previously approved these changes Oct 19, 2023
Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

test/Base.t.sol Outdated Show resolved Hide resolved
@PaulRBerg
Copy link
Member

Feel free to re-review and then we can merge, @andreivladbrg.

@andreivladbrg
Copy link
Member Author

Feel free to re-review and then we can merge

I am not in favor of removing the struct because we may add more contracts in the future in this repo and we might need to add it again, I suggest we keep.

Also, I don't know why but you pushed the old v2-core version, I pushed a commit bumping the version.

@andreivladbrg
Copy link
Member Author

For simplicity I am going to remove your commit, and just fix the typos

@PaulRBerg
Copy link
Member

PaulRBerg commented Oct 19, 2023

I am not in favor of removing the struct because we may add more contracts in the future in this repo and we might need to add it again

I disagree on the basis of YAGNI but I'm not going to argue about this, feel free to do as you wish

I don't know why but you pushed the old v2-core version

Sorry, my bad. forgot to reinit the submodules

@andreivladbrg andreivladbrg force-pushed the feat/remove-plugin-and-archive branch from 90c6212 to ffa65fa Compare October 19, 2023 11:04
@andreivladbrg andreivladbrg merged commit 2489849 into main Oct 19, 2023
7 checks passed
@PaulRBerg PaulRBerg deleted the feat/remove-plugin-and-archive branch October 19, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "ProxyPlugin" and "Archive"
2 participants