-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "ProxyPlugin" and "Archive" #213
Conversation
refactor: update scripts accordingly test: update tests accordingly ci: update ci workflows accordingly
You can remove it. Git itself is a history tracker, and we also have version tags, which we can easily checkout if the need arises for looking up these contracts in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Feel free to re-review and then we can merge, @andreivladbrg. |
I am not in favor of removing the struct because we may add more contracts in the future in this repo and we might need to add it again, I suggest we keep. Also, I don't know why but you pushed the old v2-core version, I pushed a commit bumping the version. |
For simplicity I am going to remove your commit, and just fix the typos |
I disagree on the basis of YAGNI but I'm not going to argue about this, feel free to do as you wish
Sorry, my bad. forgot to reinit the submodules |
90c6212
to
ffa65fa
Compare
Closes #212
For historical reasons, I have pushed a branch to keep the contracts, in case we need them at some point in the future.