-
Notifications
You must be signed in to change notification settings - Fork 8
refactor: remove protocol fee checks in MerkleStreamerLL
#257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOCKUP
is no longer used in abstract contract MerkleStreamer
, thus it should be removed
v2-periphery/src/abstracts/SablierV2MerkleStreamer.sol
Lines 37 to 38 in 566deba
/// @inheritdoc ISablierV2MerkleStreamer | |
ISablierV2Lockup public immutable override LOCKUP; |
This PR should have basically undo the changes made here: #220
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a beautiful PR body message, thanks for the detailed report, @smol-ninja.
Feedback below.
4beaef9
to
cf81e35
Compare
docs: remove outdated natspec
cf81e35
to
f72e402
Compare
@smol-ninja pushed a new commit, can you double check that the PR looks good now? |
Thanks Andrei for the commit. I didn't notice those Notes in the interface file. Looks good to me now. |
Closes #256
Description
This PR removes protocol fee checks in MerkleStreamerLL and allows claiming even when the protocol fee is greater than 0. When$protocolFee>0$ then ${claimAmount}=(amount - protocolFee)$ .
Changes
_checkClaim
andclawback
.SablierV2MerkleStreamer_ProtocolFeeNotZero
.Testing
test_RevertGiven_ProtocolFeeNotZero
and addstest_Claim_ProtocolFeeNotZero
.givenProtocolFeeZero
andgivenProtocolFeeNotZero
as clawback does not check for protocol fee anymoreRelated: https://github.com/sablier-labs/company-discussions/discussions/28