test: fix bound related bug in fork tests

[smol-ninja]

Resolves #277.

Bug fixed by this PR

The following lines bound vars.amounts[i] to [1, BIGNUM] but not params.leafData[i].amount.

v2-periphery/test/fork/merkle-streamer/MerkleStreamerLL.t.sol

Lines 76 to 78 in a0712ca

	// Bound each leaf amount so that `aggregateAmount` does not overflow.
	vars.amounts[i] = uint128(_bound(params.leafData[i].amount, 1, MAX_UINT256 / vars.recipientsCount - 1));
	vars.aggregateAmount += params.leafData[i].amount;

That means if params.leafData[i].amount is 0, vars.aggregateAmount would be 0 but vars.amounts[i] would be non-zero.

This would lead to the token dealing with 0 amount but .claim() would be called with non-zero value of vars.amounts causing ERC20: transfer amount exceeds balance since there would be 0 balance in merkleStreamerLL contract.

v2-periphery/test/fork/merkle-streamer/MerkleStreamerLL.t.sol

Line 124 in a0712ca

deal({ token: address(asset), to: address(vars.merkleStreamerLL), give: vars.aggregateAmount });

v2-periphery/test/fork/merkle-streamer/MerkleStreamerLL.t.sol

Lines 153 to 158 in a0712ca

	vars.actualStreamId = vars.merkleStreamerLL.claim({
	index: vars.indexes[params.posBeforeSort],
	recipient: vars.recipients[params.posBeforeSort],
	amount: vars.amounts[params.posBeforeSort],
	merkleProof: getProof(leaves.toBytes32(), vars.leafPos)
	});

[PaulRBerg]

Fantastic sleuthing, @smol-ninja.

[PaulRBerg]

lgtm

[PaulRBerg]

@smol-ninja it looks like we haven't rebased from main? I cannot see this fix on staging:

v2-periphery/test/fork/merkle-lockup/MerkleLockupLL.t.sol

Lines 78 to 80 in 06ffb31

	// Bound each leaf amount so that `aggregateAmount` does not overflow.
	vars.amounts[i] = uint128(_bound(params.leafData[i].amount, 1, MAX_UINT256 / vars.recipientsCount - 1));
	vars.aggregateAmount += vars.amounts[i];

[PaulRBerg]

Nevermind, I think you've fixed it on staging by adding vars.amounts[i] instead of params.leafData[i].amount. This means that bounding the leaf data is no longer necessary.

[smol-ninja]

Yes @PaulRBerg.