Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v.1.2.0 #364

Merged
merged 68 commits into from
Jul 4, 2024
Merged

Release v.1.2.0 #364

merged 68 commits into from
Jul 4, 2024

Conversation

andreivladbrg
Copy link
Member

No description provided.

smol-ninja and others added 30 commits February 15, 2024 18:51
test: undo changes in Murky.sol
docs: remove outdated natspec
* refactor: rename create functions to match v2-core

* build: install v2 core from staging branch

* test: deploy v2-core dependencies for fork testing

* test: update function name

---------

Co-authored-by: andreivladbrg <[email protected]>
* feat: add `name` string parameter in MerkleStreamer contract constructor
refactor: use struct `CreateWithLockupLinear` in Merkle streamer constructor

* test: name should not exceed 32 bytes

* refactor: use an struct for MerkleStreamer constructor parameters

* test: rename defaults function

* refactor: rename custom error

chore: small rewording changes
refactor: update import

* refactor: add constructor params in event

test: update tests accordingly
chore: remove unused imports

* refactor: use internal for NAME

* refactor: rename params to baseParams when referring to ConstructorParams struct

* build: update bun lockfile

---------

Co-authored-by: andreivladbrg <[email protected]>
Co-authored-by: Paul Razvan Berg <[email protected]>
refactor: use struct `CreateWithLockupLinear` in Merkle streamer constructor

test: name should not exceed 32 bytes

refactor: use an struct for MerkleStreamer constructor parameters

test: rename defaults function

refactor: rename custom error

chore: small rewording changes
refactor: update import

refactor: add constructor params in event

test: update tests accordingly
chore: remove unused imports

refactor: use internal for NAME

refactor: Rename MerkleStreamer to MerkleLockup

ci: update step name

refactor: capitalize Lockup
* test: add "ASSET" variable in Fork.t.sol to store forked asset
refactor: name default test asset to "dai"
test: use low-level call to approve contract via approveContract()
doc: add dev comment to USDC.t.sol and USDT.t.sole

* test: define a computeMerkleLockupLLAddress without asset_ parameter
test: use StreamLL struct
fix: remove additional implementation of name()
* feat: implement SablierV2MerkleLockupLT contract

feat: add createMerkleLockupLT in SablierV2MerkleLockupFactory contract

* build: include Tranched contracts in prepare-artifacts

* chore: use plural for tranches percantages

docs: add requirements in createMerkleLockupLT natspec
chore: improve wording in explanatory comments

* fix: handle the case when protocol fee is greater than zero

test: add Merkle Lockup LT integration tests

* refactor: rename variables

test: add fork tests for Merkle Lockup LT

* test: remove unused import

test: use pragma >=0.8.22

* chore: add named arg in custom error

test: createMerkleLockupLT in factory
test: update Precompiles bytecode

* refactor: use plural in getter function

test: getTranchesWithPercentages function
test: update Precompiles bytecode

* feat: add CreateMerkleLockupLT in script
refactor: use maxCount in DeployProtocol script

* test: add LT fork tests for USDC and USDT

* ci: add fork tests to ci with 20 runs

* refactor: order imports alphabetically (#301)

* refactor: remove protocol fee handle in _calculateTranches

build: bump core
test: dry-fy fork tests
test: remove protocol fee tests in claim
test: add headers in MerkleLockup
test: emit the correct element in the assertEq
test:

* refactor: remove getTranchesWithPercentages test

* refactor: rename struct variable to unlockPercentage

chore: improve explanatory comments
test: fix fork test for MerkleLockupLT

* build: update lockfile

* docs: add unlock with percentages in Lockup Tranche
test: remove protocol feee branch from claim.tree

* refactor: rename variable to totalPercentage

* test: increase coverage by testing when there is a rounding error in
tranches' amounts calculation

* test: improve rounding error test in claim

* chore: be more precise in explanatory comment

---------

Co-authored-by: smol-ninja <[email protected]>
test: lockup tranched batch functions
refactor: remove protocol fee and comptroller
test: update Precompiles bytecode
feat: new deployProtocol function in Precompiles contract

chore: ignore precompiles in codecov
PaulRBerg and others added 25 commits April 12, 2024 13:35
* refactor: alphabetical constructor params

* refactor: update precompiles

test: update formatting in comments

* test: dev comments

---------

Co-authored-by: smol-ninja <[email protected]>
* refactor: use CREATE instead of CREATE2

* test: use vm.computeCreateAddress instead

---------

Co-authored-by: andreivladbrg <[email protected]>
* feat: grace period mechanism for clawback

* feat: add a helper function for grace period

feat: add a getter function for first claim time
test: remove unneeded functions from MerkleLockup_Integration_Test
test: remove unneeded claimIndex from clawback tests
test: add FIRST_CLAIM_TIME to Defaults

* chore: add override specifier

* refactor: update precompiles

* test: add test for getFirstClaimTime

---------

Co-authored-by: andreivladbrg <[email protected]>
* refactor: rename Range struct to Timestamp

* refactor: rename timestamp to timestamps

* refactor: rename Timestamp to Timestamps
docs: move `_checkClaim` to internal non-constant section
build: update evm version to `shanghai`
* docs: update security assumptions

* build: update bun

---------

Co-authored-by: smol-ninja <[email protected]>
* build: bump solc

* build: bump deps

* chore: update bun lockfile

* build: bump core

* chore: update precompiles

---------

Co-authored-by: andreivladbrg <[email protected]>
* feat: use create2 to deploy merkle lockup campaigns

* test: computeMerkleLL and computeMerkleLT

* build: update bun lockfile

* chore: update precompiles

* refactor: remove compute functions

* refactor: calculate "totalPercentage" in MerkleLT

refactor: remove total percentage from salt

* feat: include msg.sender in create2 salt

* chore: update precompiles

* refactor: add tranchesWithPercentages to create2 salt

* chore: update bun lockfile

* build: update precompiles

* docs: use contract state

---------

Co-authored-by: Paul Razvan Berg <[email protected]>
* feat: isValidMerkleLT

* chore: update precompile

* chore: update bun lockfile

* docs: improve natspec

* refactor: isPercentagesSum100

* docs: polish NatSpec

test: polish tests

---------

Co-authored-by: andreivladbrg <[email protected]>
Co-authored-by: Paul Razvan Berg <[email protected]>
* feat: isValidMerkleLT

* chore: update precompile

* perf: declare a count for tranches length

* chore: update precompiles

---------

Co-authored-by: smol-ninja <[email protected]>
* docs: add gas benchmarks for Batch lockup

* doc(benchmark): use various batch size

* test: rename variables

test: misc enhancements

* test(benchmark): use n/a in the benchmark table

---------

Co-authored-by: Paul Razvan Berg <[email protected]>
* docs: roll 1.2.0

* build: npm ignore file in test utils

* docs(refactor): use bump

* docs(refactor): use bump in OpenZeppelin

* docs: add merklelockup and batchlockup changelog for lockup tranched

* docs: update changelog

* andrei suggestion

* docs(changelog): add solc update

* docs(changelog): add core bump pr

* docs: update date

---------

Co-authored-by: andreivladbrg <[email protected]>
Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

@andreivladbrg andreivladbrg merged commit ed3be5d into main Jul 4, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants