-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v.1.2.0 #364
Merged
Merged
Release v.1.2.0 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: undo changes in Murky.sol
docs: remove outdated natspec
* refactor: rename create functions to match v2-core * build: install v2 core from staging branch * test: deploy v2-core dependencies for fork testing * test: update function name --------- Co-authored-by: andreivladbrg <[email protected]>
* feat: add `name` string parameter in MerkleStreamer contract constructor refactor: use struct `CreateWithLockupLinear` in Merkle streamer constructor * test: name should not exceed 32 bytes * refactor: use an struct for MerkleStreamer constructor parameters * test: rename defaults function * refactor: rename custom error chore: small rewording changes refactor: update import * refactor: add constructor params in event test: update tests accordingly chore: remove unused imports * refactor: use internal for NAME * refactor: rename params to baseParams when referring to ConstructorParams struct * build: update bun lockfile --------- Co-authored-by: andreivladbrg <[email protected]> Co-authored-by: Paul Razvan Berg <[email protected]>
refactor: use struct `CreateWithLockupLinear` in Merkle streamer constructor test: name should not exceed 32 bytes refactor: use an struct for MerkleStreamer constructor parameters test: rename defaults function refactor: rename custom error chore: small rewording changes refactor: update import refactor: add constructor params in event test: update tests accordingly chore: remove unused imports refactor: use internal for NAME refactor: Rename MerkleStreamer to MerkleLockup ci: update step name refactor: capitalize Lockup
test: add ERC20Mock
* test: add "ASSET" variable in Fork.t.sol to store forked asset refactor: name default test asset to "dai" test: use low-level call to approve contract via approveContract() doc: add dev comment to USDC.t.sol and USDT.t.sole * test: define a computeMerkleLockupLLAddress without asset_ parameter
test: use StreamLL struct
fix: remove additional implementation of name()
* feat: implement SablierV2MerkleLockupLT contract feat: add createMerkleLockupLT in SablierV2MerkleLockupFactory contract * build: include Tranched contracts in prepare-artifacts * chore: use plural for tranches percantages docs: add requirements in createMerkleLockupLT natspec chore: improve wording in explanatory comments * fix: handle the case when protocol fee is greater than zero test: add Merkle Lockup LT integration tests * refactor: rename variables test: add fork tests for Merkle Lockup LT * test: remove unused import test: use pragma >=0.8.22 * chore: add named arg in custom error test: createMerkleLockupLT in factory test: update Precompiles bytecode * refactor: use plural in getter function test: getTranchesWithPercentages function test: update Precompiles bytecode * feat: add CreateMerkleLockupLT in script refactor: use maxCount in DeployProtocol script * test: add LT fork tests for USDC and USDT * ci: add fork tests to ci with 20 runs * refactor: order imports alphabetically (#301) * refactor: remove protocol fee handle in _calculateTranches build: bump core test: dry-fy fork tests test: remove protocol fee tests in claim test: add headers in MerkleLockup test: emit the correct element in the assertEq test: * refactor: remove getTranchesWithPercentages test * refactor: rename struct variable to unlockPercentage chore: improve explanatory comments test: fix fork test for MerkleLockupLT * build: update lockfile * docs: add unlock with percentages in Lockup Tranche test: remove protocol feee branch from claim.tree * refactor: rename variable to totalPercentage * test: increase coverage by testing when there is a rounding error in tranches' amounts calculation * test: improve rounding error test in claim * chore: be more precise in explanatory comment --------- Co-authored-by: smol-ninja <[email protected]>
test: lockup tranched batch functions
refactor: remove protocol fee and comptroller test: update Precompiles bytecode
Feat/add tranched batches
feat: new deployProtocol function in Precompiles contract chore: ignore precompiles in codecov
* refactor: alphabetical constructor params * refactor: update precompiles test: update formatting in comments * test: dev comments --------- Co-authored-by: smol-ninja <[email protected]>
docs: update security assumptions
* refactor: use CREATE instead of CREATE2 * test: use vm.computeCreateAddress instead --------- Co-authored-by: andreivladbrg <[email protected]>
* feat: grace period mechanism for clawback * feat: add a helper function for grace period feat: add a getter function for first claim time test: remove unneeded functions from MerkleLockup_Integration_Test test: remove unneeded claimIndex from clawback tests test: add FIRST_CLAIM_TIME to Defaults * chore: add override specifier * refactor: update precompiles * test: add test for getFirstClaimTime --------- Co-authored-by: andreivladbrg <[email protected]>
docs: move `_checkClaim` to internal non-constant section
build: update evm version to `shanghai`
* docs: update security assumptions * build: update bun --------- Co-authored-by: smol-ninja <[email protected]>
* build: bump solc * build: bump deps * chore: update bun lockfile * build: bump core * chore: update precompiles --------- Co-authored-by: andreivladbrg <[email protected]>
* feat: use create2 to deploy merkle lockup campaigns * test: computeMerkleLL and computeMerkleLT * build: update bun lockfile * chore: update precompiles * refactor: remove compute functions * refactor: calculate "totalPercentage" in MerkleLT refactor: remove total percentage from salt * feat: include msg.sender in create2 salt * chore: update precompiles * refactor: add tranchesWithPercentages to create2 salt * chore: update bun lockfile * build: update precompiles * docs: use contract state --------- Co-authored-by: Paul Razvan Berg <[email protected]>
* feat: isValidMerkleLT * chore: update precompile * chore: update bun lockfile * docs: improve natspec * refactor: isPercentagesSum100 * docs: polish NatSpec test: polish tests --------- Co-authored-by: andreivladbrg <[email protected]> Co-authored-by: Paul Razvan Berg <[email protected]>
* feat: isValidMerkleLT * chore: update precompile * perf: declare a count for tranches length * chore: update precompiles --------- Co-authored-by: smol-ninja <[email protected]>
* docs: add gas benchmarks for Batch lockup * doc(benchmark): use various batch size * test: rename variables test: misc enhancements * test(benchmark): use n/a in the benchmark table --------- Co-authored-by: Paul Razvan Berg <[email protected]>
* docs: roll 1.2.0 * build: npm ignore file in test utils * docs(refactor): use bump * docs(refactor): use bump in OpenZeppelin * docs: add merklelockup and batchlockup changelog for lockup tranched * docs: update changelog * andrei suggestion * docs(changelog): add solc update * docs(changelog): add core bump pr * docs: update date --------- Co-authored-by: andreivladbrg <[email protected]>
smol-ninja
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.