Add PHP 8.4 compliance for 2.2 branch #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
force-pushed
the
php-8.4-ci-for-2.2
branch
from
e223c27 to
b16cd91
Compare
phil-davis
commented
Jul 25, 2024
| if: matrix.code-analysis == 'yes' | ||
| run: php vendor/bin/php-cs-fixer fix --dry-run --diff | ||
| if: matrix.code-style == 'yes' | ||
| run: PHP_CS_FIXER_IGNORE_ENV=true php vendor/bin/php-cs-fixer fix --dry-run --diff |
There was a problem hiding this comment.
This is handy to specify if we want to run the "old" php-cs-fixer with a more modern version of PHP.
It is not essential to specify now, because we are only running it with PHP 7.1 in CI. But I will leave it here so I have it in future, it does no harm.
phil-davis
changed the title
|
@cedric-anne here is what seems to be needed for https://github.com/sabre-io/xml 2.2 release series. When this has been approved, I will apply similar to the later major release series. |
cedric-anne
approved these changes
Jul 25, 2024
staabm
approved these changes
Jul 25, 2024
|
Hi @phil-davis This is weird, the 2.2.8 version cannot be downloade by composer, because it is not listed in https://repo.packagist.org/p2/sabre/xml.json . However, this version is present in the corresponding packagist page https://packagist.org/packages/sabre/xml#2.2.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue sabre-io/event#123
?to keep PHP 8.4 happyreportUnmatchedIgnoredErrorsin PHPstan. PHPstan, when run in PHP 7.1, thinks that a call tostartElementNshas a problem. But, when run with PHP 8.4, it correctly understands that the call is fine. So we don't want to report the unmatched ignored error.