Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): add GetTransactions + export more types #105

Merged
merged 4 commits into from
Jan 17, 2024
Merged

feat(sdk): add GetTransactions + export more types #105

merged 4 commits into from
Jan 17, 2024

Conversation

kevzzsk
Copy link
Collaborator

@kevzzsk kevzzsk commented Jan 15, 2024 •
edited
Loading

What this PR does / why we need it:

  1. export more typing
  2. add GetTransactions RPC
  3. update GetInscriptions RPC to include includePostage params

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors
  • Unit tests*
  • Added e2e tests*

danadi7
danadi7 reviewed Jan 16, 2024
View reviewed changes
packages/sdk/src/api/types.ts Outdated Show resolved Hide resolved
packages/sdk/src/api/types.ts Outdated Show resolved Hide resolved
joundy
joundy approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@joundy joundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the RPC request

danadi7
danadi7 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@danadi7 danadi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nanosync Nanosync merged commit d0662c8 into sadoprotocol:main Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danadi7 danadi7 danadi7 approved these changes

@joundy joundy joundy approved these changes

@Nanosync Nanosync Nanosync approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevzzsk @Nanosync @joundy @danadi7