Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add derivation-path option to load ledger owners #294

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Add derivation-path option to load ledger owners #294

merged 2 commits into from
Nov 7, 2023

Conversation

moisses89
Copy link
Member

Closes #284

@moisses89 moisses89 requested a review from Uxio0 as a code owner November 6, 2023 17:03
@coveralls
Copy link

coveralls commented Nov 6, 2023 •
edited
Loading

Coverage Status

coverage: 92.904% (+0.1%) from 92.799%
when pulling a604c5a on add_derivation_path_option
into a4ce370 on master.

@moisses89 moisses89 marked this pull request as draft November 7, 2023 07:40
@moisses89 moisses89 force-pushed the add_derivation_path_option branch from 52ebe90 to 509a695 Compare November 7, 2023 09:45
@moisses89 moisses89 force-pushed the add_derivation_path_option branch from 509a695 to ea1ee95 Compare November 7, 2023 09:48
@moisses89 moisses89 marked this pull request as ready for review November 7, 2023 10:03
Uxio0
Uxio0 requested changes Nov 7, 2023
View reviewed changes
safe_cli/operators/safe_operator.py Show resolved Hide resolved
safe_cli/operators/safe_operator.py Outdated Show resolved Hide resolved
safe_cli/prompt_parser.py Outdated Show resolved Hide resolved
@moisses89 moisses89 force-pushed the add_derivation_path_option branch from 622fbbb to a604c5a Compare November 7, 2023 11:54
@moisses89 moisses89 requested a review from Uxio0 November 7, 2023 11:55
@moisses89 moisses89 merged commit c46baaf into master Nov 7, 2023
8 checks passed
@moisses89 moisses89 deleted the add_derivation_path_option branch November 7, 2023 12:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support load_ledger_cli_owners from DERIVATION_PATH
3 participants
@moisses89 @coveralls @Uxio0