Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamically fetch DAO voting stats #268

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Conversation

DiogoSoaress
Copy link
Member

@DiogoSoaress DiogoSoaress commented Feb 7, 2024

What it solves

Replaces image assets by API calls to return

  • number proposals

  • number of unique delegates

  • number of delegators

    Screenshot 2024-02-08 at 00 56 54

Fixes the Snapshot title parsing
Screenshot 2024-02-08 at 11 02 33

How this PR fixes it

Fetches the voting numbers in getStaticProps similarly to what we do for SafeStats and shares them through a VotingDelegationContext

Copy link

github-actions bot commented Feb 7, 2024

Branch preview

⏳ Deploying a preview site...

Copy link

github-actions bot commented Feb 8, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@DiogoSoaress DiogoSoaress marked this pull request as ready for review February 8, 2024 10:12
Copy link

@compojoom compojoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@DiogoSoaress DiogoSoaress merged commit 1afbb1d into main Feb 8, 2024
4 of 5 checks passed
@DiogoSoaress DiogoSoaress deleted the dynamic-gov-stats branch February 8, 2024 12:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants