-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linkbuilding page added: holding-crypto-safely #547
base: main
Are you sure you want to change the base?
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
const handleClick = (e: React.MouseEvent<HTMLAnchorElement>, target: string) => { | ||
e.preventDefault() | ||
|
||
// TODO: move offset to CSS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be addressed before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component was copied from the Core/Intro/index.tsx - the as the TODO was pre-existing I decided to leave it in.
) | ||
} | ||
|
||
// TODO: unify the ItemGrid and accept a GridItem component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be addressed before the merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component was copied from the common/UspBlock/index.tsx
- the as the TODO was pre-existing I decided to leave it in.
) | ||
} | ||
|
||
// TODO: unify the ItemGrid and accept a GridItem component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again need to addressed before merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component was copied from the common/UspBlock/index.tsx - the as the TODO was pre-existing I decided to leave it in.
@NotRohan Thank you for your comments - for clarification on the TODO comments - these action points existed in your main branch so I assumed these would need to be replicated for any future refactoring. Thanks. |
What it solves
New link building page for outreach built by Reddico.