Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkbuilding page added: holding-crypto-safely #547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OhColar
Copy link

@OhColar OhColar commented Feb 3, 2025

What it solves

New link building page for outreach built by Reddico.

Copy link

github-actions bot commented Feb 3, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@OhColar
Copy link
Author

OhColar commented Feb 3, 2025

I have read the CLA Document and I hereby sign the CLA

const handleClick = (e: React.MouseEvent<HTMLAnchorElement>, target: string) => {
e.preventDefault()

// TODO: move offset to CSS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be addressed before merging?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component was copied from the Core/Intro/index.tsx - the as the TODO was pre-existing I decided to leave it in.

)
}

// TODO: unify the ItemGrid and accept a GridItem component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be addressed before the merge?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component was copied from the common/UspBlock/index.tsx - the as the TODO was pre-existing I decided to leave it in.

)
}

// TODO: unify the ItemGrid and accept a GridItem component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again need to addressed before merge?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component was copied from the common/UspBlock/index.tsx - the as the TODO was pre-existing I decided to leave it in.

cryptobuks pushed a commit to groundbasesoft/cla-signatures that referenced this pull request Feb 21, 2025
@OhColar
Copy link
Author

OhColar commented Feb 24, 2025

@NotRohan Thank you for your comments - for clarification on the TODO comments - these action points existed in your main branch so I assumed these would need to be replicated for any future refactoring. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants