-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add events for receiving and sending #133
Comments
👍 |
@ligi @mpetrunic could you comment on the PR what parameters you would like to see and what information should be indexed. |
Something like TxInitiated, TxConfirmed and TxExecuted with address of actor so we can setup notifications with some existing service like Tenderly when something happens. Instead of pinging team members and checking safe website every morning. I don't think I need anything indexed. |
See #135 for all the events. |
Closes #133: Added events + required refactoring
As discussed with @rmeissner at the demo day before Devcon - opening this as an issue:
I understand that the events where not added to save gas-costs. But the costs are now just there in another form: the form of centralization and the need to run tracing servers. So I would love to open the discussion to change this. At least for receiving there should be an event thrown. IMHO the costs would not be significant and the benefits would outweigh the costs. Let me know what you think!
context:
https://gitter.im/gnosis/Safe?at=5d8c7a97290b8c354ad93891
coder5876/simple-multisig#41 (comment)
The text was updated successfully, but these errors were encountered: