-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #133: Added events + required refactoring #135
Conversation
Alternative to the Execution and ExecutionPayment events (to save some gas):
|
Thanks for the fast PR to address #133 - event looks good to me - hope it will get merged. |
updated events for gas efficiency: transaction details have been removed from events, only the transaction hash and the payment are part of the event, the rest needs to be retrieved from other sources (e.g. the Ethereum transaction or our service). |
f006a6a
to
dbea5bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
…vice-endpoint Update Transaction Service endpoint in Safe Service Client tests
Closes #133
This PR adds events for all kinds of interactions with the Safe. This will make it easier for 3rd party clients to monitor Safe instances.
The additional costs are between 2% when executing a transaction. For incoming transactions there is an additional 1k required.
Current event definitions (for a better overview):