Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.0 libs.0 zksync #588

Merged
merged 79 commits into from
Nov 26, 2024
Merged

Conversation

nick8319
Copy link

This PR adds support to test and deploy safe-contracts 1.3.0 to zkSync network.
The process is described in zkSync Network section in Readme.md

@nick8319 nick8319 marked this pull request as ready for review June 28, 2023 18:21
@rmeissner
Copy link
Member

Just to note: we will not merge this PR as this is just a temporary solution to deploy 1.3.0.
The final goal is to enable this for 1.4.1 and make this a default for all zkSync chains

@remedcu
Copy link
Member

remedcu commented Nov 20, 2024

Just to note: we will not merge this PR as this is just a temporary solution to deploy 1.3.0.
The final goal is to enable this for 1.4.1 and make this a default for all zkSync chains

Should we close this PR considering now we have zkSync support in v1.4.1?

Copy link

@gatleas17 gatleas17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help

@nlordell
Copy link
Collaborator

Should we close this PR considering now we have zkSync support in v1.4.1?

Yes, but let's keep the branch around in case we need to deploy v1.3.0 contracts to a zkSync chain.

@mmv08 mmv08 merged commit b3f5399 into safe-global:v1_3_0_zksync Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants