fix: Sidebar for policy domain #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
arunanshub
approved these changes
Feb 17, 2025
arunanshub
pushed a commit
that referenced
this pull request
Feb 17, 2025
arunanshub
pushed a commit
that referenced
this pull request
Feb 21, 2025
abhisek
added a commit
that referenced
this pull request
Feb 21, 2025
* deps: update lockfile * feat: add initial policy page design * feat: add policy group page content * refactor: change button label * refactor: make names bold * feat: add edit policy group page * feat: add buttons and data to page * feat: add create policy group page * feat: add create policy page * feat: fix tags-input type errors * feat: add rulecheck schema * feat: add rule component * feat: beautify rule component * refactor: clean up code * fix: prevent form from submitting when enter is pressed * feat: make rule collapsible for ease of access * feat: prepend instead of append rules * feat: add edit policy page * feat: add edit/create states * fix: handle submission logic from parent * fix: rename form to policy-form * fix: convert page to client component * feat: add link to policy page * feat: add attach/detach policies functionality * refactor: remember what policies were selected * refactor: change handleUpdateGroup to a function declaration * refactor: exclude already attached policy * refactor: use deterministic mock data gen * feat: add responsive dialog * fix: update links * fix: fix row layout on mobile * fix: Sidebar for policy domain (#86) * feat: fetch policy groups * feat: add create policy actions * feat: allow deleting group * feat: list policies * feat: list policies using datatable * feat: connect create policy action to page * feat: add edit policy feature * fix: send to correct link * feat: remove policy id from table * feat: use tanstack query to auto manage loading/error state * feat: allow directly submitting the rule value on the basis of rule name * feat: add update policy form * feat: use default form behavior * fix: make textarea resizable and redirect to policy list * refactor: extract component and add delete functionality * feat: show spinner when row is being deleted * feat: manually verify if rules are present * feat: add attach/detatch server actions * feat: allow updating policy group * feat: implement attach/detach feature * refactor: make mutations async * remove react-query toolbar * refactor: show proper label * refactor: use custom hook * refactor: consolidate tenant and token retrieval into a single function and fix policy listing * refactor: update policy form and actions with consistent naming and improved type handling * refactor: extract getTenantAndToken to shared RPC client module * feat: enhance policy edit page with React Query mutation and toast notifications * refactor: add toast notifications for policy group mutations * chore: upgrade dependencies and migrate to Sonner toast notifications * fix: show toasts and fix dropdown menu using query * feat: implement server-side rendering with Tanstack Query for policy management page * refactor: let tanstack query devtools be there * refactor: migrate policy list page to hybrid rendering with Tanstack Query * refactor: improve policy group creation with Tanstack Query and optional description * feat: add createdAt and updatedAt timestamps to policy groups * test: add policy list page test * test: check for row contents * test: track error states * test: add tests for policy management page * test: add test for policy-management new policy page * test: skip a flaky test * test: keep the test but skip it for now * refactor: move session related code to session.ts * refactor: adopt to bufbuild v2 --------- Co-authored-by: Abhisek Datta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.