-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow lzma compressed data file #4
Conversation
I'd like this too, but I'd prefer to just do it as part of the |
I should mention: I don't know how to do it with this week's python build tooling or else I would just do it. I'll ask around. |
Since you are using setuptools, it would just be done by customizing |
I don't know how to fix this. It works if one builds a wheel ( |
Question: the sdist should contain the original txt file, or the compressed file? |
Ok, this seems to work: the |
I spent at least an hour trying to find out what I needed to add to pyproject.toml to override build_py, and you're telling me it just works?? I think you did the right thing with the sdist. I pushed the changes, added some types, and tagged version 0.9. Matthias has to do the pypi release and then I guess we'll see how it all works in real life. |
Actually it's all automated. It ran here when you pushed the tag: https://github.com/sagemath/conway-polynomials/actions/runs/7509952087/job/20447737402#step:7:82 |
Oh, even better. The first time you had to re-push my tag, I assumed it was a permissions issue, and not just a you had to push a tag issue. |
An attempt at #3.
This will use
CPimport.txt.lzma
if available, else fallback toCPimport.txt
as before.Note that this doesn't attempt to compress the file at install time, since I don't know how to do that. But one could e.g. compress the file when packaging for a distro, and it would work transparently. I do this for pari data, which support replacing text files by gzipped files.