Polish the various utility scripts + fix bugs #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pv
force-pushed
the
script-polish
branch
2 times, most recently
from
f019e55 to
5aaa0c8
Compare
Use argparse for more friendly argument parsing, and rename script files so that they can be put on PATH. Add them as script files in setup.py, and install also sagetexparse.py module.
It's working with pyparsing 2.4.7 Add sagestr support. Sageexample environment is still not supported (cherry-picked from pull request sagemath#55 by @vincek59)
Fix pyparsing compatibility, and dedent code appropriately. Also, use a different comment prefix for comments output by the extraction tool.
|
Sorry, I missed this PR back in April, as for some reason notifications on this repo aren't working for me. Thanks a lot for contributing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the following problems:
makestatic.pyandextractsagecode.pydon't work correctly with current Pyparsing versions~/bin/sage, Latex files are in cwd, etc.So:
Add asagetex-toolscript that can be installed on PATH (unlike makestatic.py etc. whose names are not suitable for that). Makesagetexa python package, make the scripts modules inside it, and makesetup.pyto installsagetex-toolas the command-line entry point. Do this in a way such that all scripts can still be run standalone, and you can also usesagetex.pyas a Python module (instead of a package) exactly as previously if you like.I guess the scripts could also instead be renamed tosagetex-makestatic,sagetex-runetc., so let me know what you think.Ok, it's simpler to just rename the scripts as
sagetex-XXXand mark them and thesagetexparser.pyto be installed in setup.py.Fix some brokenness and inconveniences. This includes a commit cherry-picked from #55 which makes makestatic.py to work again with current pyparsing versions. extractsagecode.py also needed some fixes.
The code assumes Python3 only.