Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.10.3 #723

Merged
merged 3 commits into from
Mar 22, 2025
Merged

Release 2.10.3 #723

merged 3 commits into from
Mar 22, 2025

Conversation

vassilit
Copy link
Collaborator

No description provided.

@fermino
Copy link
Collaborator

fermino commented Mar 20, 2025

Should we add a (soft) requirements that all PRs should update the changelog accordingly? (I'm not used to it so it might be more of a personal rule 😄)

@vassilit vassilit force-pushed the release/2.10.3 branch 3 times, most recently from aa238db to 1913445 Compare March 20, 2025 17:17
@vassilit vassilit linked an issue Mar 20, 2025 that may be closed by this pull request
2.10.3 #692
Closed
@vassilit vassilit self-assigned this Mar 20, 2025
@vassilit vassilit force-pushed the release/2.10.3 branch 3 times, most recently from 0b27077 to 93a84c3 Compare March 21, 2025 13:46
@vassilit
Copy link
Collaborator Author

@fermino I've seen you tried to revert the documentation commit. Do you think it is harmful in some way ?

@fermino
Copy link
Collaborator

fermino commented Mar 22, 2025

@vassilit which one? If I did it was probably a mistake, but I'm a bit lost. Do you mean in a PR?

@vassilit
Copy link
Collaborator Author

@vassilit which one? If I did it was probably a mistake, but I'm a bit lost. Do you mean in a PR?

I'm talking about 179515d

@vassilit
Copy link
Collaborator Author

@vassilit which one? If I did it was probably a mistake, but I'm a bit lost. Do you mean in a PR?

Also, could you pre-approve this PR ? I think we're ready for a release. I wait for #573, will rebase this branch to it, to master and hopefully we could release 2.10.3 today.

What do you think ?

@fermino
Copy link
Collaborator

fermino commented Mar 22, 2025

Oh my goodness, I don't even recall that. It was signed by GitHub web's interface so maybe it was a missclick? Or maybe something I clicked in other PR that triggered an action here? I find it super odd.

In any case, I'm really sorry about that! D:

About the PR, sure! IDK if the approval "expires" after rebasing but in any case just ping me and I will approve it again.

@vassilit
Copy link
Collaborator Author

About the PR, sure! IDK if the approval "expires" after rebasing but in any case just ping me and I will approve it again.

No, it doesn't expire. I find it rather strange. I can add any additional commits or modify the existing ones and the approval is still valid. It's not normal, but heh, I won't do nothing silly here I promise :)

@vassilit
release 2.10.3
2fe7dc8 
Signed-off-by: Vassili Tchersky <[email protected]>
@vassilit vassilit merged commit 2fe7dc8 into master Mar 22, 2025
16 of 32 checks passed
@vassilit vassilit deleted the release/2.10.3 branch March 22, 2025 08:23
@RayOei
Copy link
Collaborator

RayOei commented Mar 22, 2025

🚀 Great work @vassilit and @fermino for getting this 🚂 moving again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fermino fermino fermino approved these changes

Assignees

@vassilit vassilit

Labels
None yet
Projects
None yet
Milestone
2.10.3 Ludicrous Lemur Bugfixes
Development

Successfully merging this pull request may close these issues.

2.10.3
3 participants
@vassilit @fermino @RayOei