Fixup build with qt6 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvuorela
reviewed
Dec 21, 2022
| QMutexLocker locker(&mutex); | ||
| #else | ||
| mutex.lock(); |
There was a problem hiding this comment.
Not following why this change? Different behavior too, nothing releases the mutex when the function is exited? Doesn't feel proper.
There was a problem hiding this comment.
Was resolved without explanation, unresolving.
QRecursiveMutex is Qt 5.14 so using that would be better, but I'm not following why a recursive mutex would be needed because of Qt version.
And then QMutexLocker works with a recursive mutex too so I'm not following why these explicit locks which are even missing the unlocks.
pvuorela
requested changes
Nov 27, 2023
neochapay
force-pushed
the
qt6
branch
2 times, most recently
from
d740afb
to
1987e91
Compare
|
@pvuorela fixed |
neochapay
force-pushed
the
qt6
branch
4 times, most recently
from
9617e4f
to
bc26e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.