PR for Issue #32 - Scroll adjust periodic attack interval while holding the keybind #33
Conversation
Added function to adjust TWEAK_PERIODIC_ATTACK_INTERVAL by scrolling while holding the TWEAK_PERIODIC_ATTACK keybind
Added "tweakeroo.message.set_periodic_attack_interval_to" String
|
Thanks for your PR. it will be nice if you can also add this to period use. |
Oh, totally. I completely forgot there are other periodic features. I'll add that as well! Do you think it would also make sense to be able to scroll adjust the period of the periodicHoldUse and periodicHoldAttack? The hold duration would remain only changeable in the config. |
yes I agree. |
Added scroll handler for PERIODIC_USE_INTERVAL, PERIODIC_HOLD_ATTACK_INTERVAL and PERIODIC_HOLD_USE_INTERVAL
Added strings "tweakeroo.message.set_periodic_use_interval_to", "tweakeroo.message.set_periodic_hold_attack_interval_to" and "tweakeroo.message.set_periodic_hold_use_interval_to"
|
Added PERIODIC_USE_INTERVAL, PERIODIC_HOLD_ATTACK_INTERVAL and PERIODIC_HOLD_USE_INTERVAL scroll handlers. |
sakura-ryoko
merged commit 117b5f0
into
sakura-ryoko:pre-rewrite/fabric/1.21
|
Seems ok, so I'll merge it. |
I managed to create a working build for the Feature Request from #32
This is my first PR on GitHub in ages, I probably did everything wrong, sorry about that X)