Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove perPage init from constructor #14

Merged
merged 1 commit into from
Dec 18, 2023
Merged

remove perPage init from constructor #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/BaseEloquentRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@

private Model $model;

private int $perPage;

public function __construct()
{
$this->perPage = config('repository.perPage');
}

/**
* This function returns the fully qualified class name of the model that the repository is responsible for.
*/
Expand Down Expand Up @@ -162,7 +155,7 @@
throw new InvalidArgumentException('Invalid page size');
}

return min($perPage, $this->perPage);
return min($perPage, config('repository.perPage'));

Check warning on line 158 in src/BaseEloquentRepository.php

View check run for this annotation

Codecov / codecov/patch

src/BaseEloquentRepository.php#L158 

Added line #L158 was not covered by tests
}

/**
Expand Down