-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement make repository command #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salehhashemi1992
force-pushed
the
stub
branch
2 times, most recently
from
March 7, 2024 15:47
4b83b23
to
cf7301a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
============================================
+ Coverage 92.85% 93.95% +1.09%
- Complexity 58 69 +11
============================================
Files 4 5 +1
Lines 168 215 +47
============================================
+ Hits 156 202 +46
- Misses 12 13 +1 ☔ View full report in Codecov by Sentry. |
salehhashemi1992
force-pushed
the
stub
branch
2 times, most recently
from
March 8, 2024 11:23
f2814b4
to
655be4d
Compare
imahmood
reviewed
Mar 9, 2024
salehhashemi1992
force-pushed
the
stub
branch
2 times, most recently
from
March 13, 2024 10:09
0c14494
to
081f9a8
Compare
imahmood
reviewed
Mar 13, 2024
It seems there's an extra backslash in the namespace declaration and use statements. /**
* Assert the correct namespace in generated files
*/
public function testHasCorrectNamespace(): void
{
$fqcn = 'App\Models\Special\\'.$this->model;
$this->artisan('make:repository', ['name' => $fqcn]);
$expectedNamespace = 'namespace App\Repositories';
$expectedFiles = [
"{$this->basePath}/{$this->model}Repository.php",
"{$this->basePath}/Contracts/{$this->model}RepositoryInterface.php",
"{$this->basePath}/Filters/{$this->model}Filter.php",
];
foreach ($expectedFiles as $file) {
$this->assertStringContainsString($expectedNamespace, file_get_contents($file));
}
} |
imahmood
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add php artisan make:repository command