#73: Inject namespace using string replacements. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sebastien <[email protected]>
Co-authored-by: Sebastien <[email protected]>
Co-authored-by: Sebastien <[email protected]>
scolladon
reviewed
Dec 11, 2024
| { | ||
| "glob": "force-app/recipes/**/*.cls", | ||
| "stringToReplace": "namespace.", | ||
| "replaceWithEnv": "SF_NAMESPACE_DOT", |
There was a problem hiding this comment.
question: SF_NAMESPACE_DOT should be used then in the github actions right ?
We should remove then this githubaction
And only use this one:
- It should take a parameter a boolean "namespace". When namespace is true it should set the
SF_NAMESPACE_DOTwith the valuemockery., else it should set it with empty string - this github action should be modified to call the only one action twice with the "namespace" boolean true for
validate-namespace-compatibilitystep and false forvalidate-package-version
Something like that ?
There was a problem hiding this comment.
That's exactly it. It should also give people the opportunity to use their own namespace if they want to fork the package (since tests in their repository will fail if it is locked to mockery).
There was a problem hiding this comment.
I'll try to contribute here soon (don't know when yet) !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid code duplication of
ApexMockeryOverviewandStubBuilderImplby using Salesforce CLI's string replacement functionality to replacenamespace.with the value of theSF_NAMESPACE_DOTenvironment variable.Description
I replaced
mockery.withnamespace.where it was hard-coded into Apex, and added the string replacements to thesfdx-project.jsonconfig file. This format for the replacement string should be more friendly to linters than alternatives like %%%NAMESPACE_DOT%%% (which is what CumulusCI uses).Because I set the
allowUnsetEnvVariableproperty to true,namespace.will be cleared if theSF_NAMESPACE_DOTenvironment variable isn't set, which allows the variable to effectively act as a toggle for namespace/non-namespace testing. This should enable a less-invasive developer experience overall while still allowing for namespace testing.Motivation and Context
#73
How Has This Been Tested?
I had some issues actually testing this in a namespace (scratch org wasn't able to be created even after adding my own namespace to the config). Apologies for not testing this in more depth prior to committing...perhaps it's fine since it will need the main repo's secrets to properly test packaging anyways. Please feel free to push back or suggest fixes; I might try again later.
I was able to text the conversion process itself by following the Test String Replacements process specified in the docs, which verified that the string replacements themselves are successful.