feat(template-compiler): enable complex template expressions #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekashida
force-pushed
the
ekashida/cte-beta
branch
from
0902611 to
b6ccbc8
Compare
ekashida
commented
Mar 28, 2024
Comment on lines
-6
to
-15
| const { d: api_dynamic_text, t: api_text, h: api_element } = $api; | ||
| return [ | ||
| api_element("section", stc0, [ | ||
| $cmp.state.isTrue | ||
| ? api_text( | ||
| api_dynamic_text($cmp.foo) + " " + api_dynamic_text($cmp.bar) | ||
| ) | ||
| : null, | ||
| ]), | ||
| ]; |
There was a problem hiding this comment.
This change is due to the fact that parse5 parses template content into a content property, whereas we're parsing it into the childNodes property, hiding it from our own downstream parsing logic.
_insertTemplate(token) {
const tmpl = this.treeAdapter.createElement(token.tagName, html_js_1.NS.HTML, token.attrs);
const content = this.treeAdapter.createDocumentFragment();
this.treeAdapter.setTemplateContent(tmpl, content);
this._attachElementToTree(tmpl, token.location);
this.openElements.push(tmpl, token.tagID);
if (this.options.sourceCodeLocationInfo)
this.treeAdapter.setNodeSourceCodeLocation(content, null);
}
most of these are incorrect and we'll be addressing them in subsequent commits
ekashida
force-pushed
the
ekashida/cte-beta
branch
from
b6ccbc8 to
4e41936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item