Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ssr): fix sync mode flag to work with concurrency #4982

Merged
merged 1 commit into from
Dec 2, 2024
Merged

test(ssr): fix sync mode flag to work with concurrency #4982

merged 1 commit into from
Dec 2, 2024

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Dec 2, 2024

Details

Turning the flag on and off for each test meant that the state becomes flaky when running concurrently.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf requested a review from a team as a code owner December 2, 2024 18:17
@wjhsf wjhsf enabled auto-merge (squash) December 2, 2024 18:23
@wjhsf wjhsf merged commit d73ee61 into master Dec 2, 2024
11 checks passed
@wjhsf wjhsf deleted the mob/concurrency branch December 2, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolanlawson nolanlawson nolanlawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjhsf @nolanlawson