fix(ssr): fix rendering scoped variables in iterators #4990
+164
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added some code to handle complex template expressions, since we need it to compile the benchmarks properly. |
wjhsf
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes an issue with rendering iterator-related variables like
item/index/it.value/etc. Adds some tests to assert that we are rendering these correctly.The bug was basically that we only supported member syntax like
item.fooand not a bare identifier like justitem.I also organized the fixtures into two top-level directories:
for-each-blockanditerator-block.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?